fix: Use proper path APIs in Folder.CopyTo() instead of string replacement#1462
Merged
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ement Replace brittle string replacement with Path.GetRelativePath() and Path.Combine() to safely compute destination paths. The previous implementation using dirPath.Replace(this, targetPath) could corrupt paths if the source path substring appeared multiple times. Fixes #1453 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
Contributor
SummaryFixes path corruption bug in Critical IssuesNone found ✅ SuggestionsNone - the fix correctly addresses the issue described in #1453 using the appropriate .NET path APIs. Verdict✅ APPROVE - No critical issues Review Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dirPath.Replace(this, targetPath)) with proper path APIs (Path.GetRelativePath()andPath.Combine())Changes
Before:
After:
Fixes #1453
Test plan
🤖 Generated with Claude Code